ctlptl icon indicating copy to clipboard operation
ctlptl copied to clipboard

[feat] support passing extra args to `kind create`

Open DerekTBrown opened this issue 1 year ago • 3 comments

What does this PR do?

  • Allows passing arbitrary extra arguments to kind. This is useful for several debugging scenarios and edge cases, described in the kind_extra_args.yaml file I included.

DerekTBrown avatar Oct 16 '24 17:10 DerekTBrown

thanks for the contribution!

high-level question - the docs say "Extra command line arguments passed to Kind CLI" -- but then you only pass arguments to kind create, not other kind cli invocations (e.g., kind delete). And your docs are mixing up create-specific flags with global flags. I'm not sure how to resolve this though?

nicks avatar Oct 19 '24 20:10 nicks

high-level question - the docs say "Extra command line arguments passed to Kind CLI" -- but then you only pass arguments to kind create, not other kind cli invocations (e.g., kind delete). And your docs are mixing up create-specific flags with global flags. I'm not sure how to resolve this though?

That's a good call out! At least for my purposes, I only need to pass CLI flags to kind create. I can rename the property accordingly.

Before I refactor: does this data model make sense to you, or should I be thinking about a more generic interface (I could imagine that other providers would want to have a similar interface)?

DerekTBrown avatar Oct 22 '24 01:10 DerekTBrown

ya, i'd be fine if it was KindCreateExtraArguments

nicks avatar Oct 22 '24 13:10 nicks