faiadashu icon indicating copy to clipboard operation
faiadashu copied to clipboard

Update to fhir 0.11.0 and flutter 3.10.0

Open sp-nazar opened this issue 2 years ago • 6 comments
trafficstars

This merge combines recent updates of fhir and flutter.

I got some errors while try to compile faiadashu with new Flutter 3.10.0. Fhir package was updated recently with these fixes.

Notice I temporary disable faiadashu_online and fhir_auth from the example, fhir_auth has not yet updated to fhir 0.11.0.

sp-nazar avatar May 24 '23 10:05 sp-nazar

please @tiloc integrate it as soon as possible

sh1l0n avatar Jun 30 '23 09:06 sh1l0n

Hi, I am experiencing issues with this PR. When I am using the Cherryblossom Filler from the example gallery, I am consistently getting an exception related to the weight field. It says it cannot locate the ucum-bodyweight value set. Can you please unbreak this? Apart from that I am in awe of all the hard work that has gone into this!

tiloc avatar Aug 24 '23 19:08 tiloc

@tiloc, we would like to help this PR to get in. Could you please share how are you running the quality check so that we can cover your exceptions as well?

AliakseiT avatar Oct 27 '23 13:10 AliakseiT

@tiloc any update? can you provide some feedback on what is the bug and how to reproduce it?

easazade avatar Nov 14 '23 07:11 easazade

@tiloc any update? can you provide some feedback on what is the bug and how to reproduce it?

Hi, @easazade , I encountered the bug when I ran the demo application and chose the "Cherryblossom Filler" example. Towards the end of the form one of the questions displays an error message instead of the question. This was not the case prior to this PR.

tiloc avatar Nov 17 '23 14:11 tiloc

Hello. I don't know if this may have to do with the bug reported by @tiloc before, but I believe there are a few unintended bugs introduced in this PR due to the removal of QuestionnaireItemType, QuestionnaireResponseStatus and other enums from the fhir package, and the way these changes were addressed.

I have marked below some of the ones I could find (there appears to be a lot more). Hope this is of help.

You may want to refer to the FHIR docs for the codes in question:

  • http://hl7.org/fhir/R4/valueset-item-type.html#expansion
  • http://hl7.org/fhir/R4/valueset-questionnaire-enable-operator.html#expansion
  • http://hl7.org/fhir/R4/valueset-questionnaire-answers-status.html#expansion

Hi,

if the latest versions of the fhir package have removed things that would be beneficial to faiadashu, then we should also consider reaching out to @Dokotela Grey Faulkenberry and see if it can be re-added. He's been quite supportive and appreciative of feedback on his packages in the past.

tiloc avatar Nov 19 '23 16:11 tiloc