cdlc_player icon indicating copy to clipboard operation
cdlc_player copied to clipboard

Music does not play

Open QEDan opened this issue 4 years ago • 6 comments

This is really great. Thank you for making this.

When I play a song in the app, the only audio is the metronome click. The music does not play. But, I can see the 3D tab for the song scrolling. I'm using LineageOS 18.1 on a Pixel 3a phone. I have version 0.0.5 of the app from F-droid.

QEDan avatar Dec 10 '21 16:12 QEDan

No, it doesn't. I should have mentioned this in the README. It's not implemented because (a) it's probably hard (the sound is encoded in some weird Wwise format), (b) implementing this would possibly make this project more of a target for lawyers and stuff.

tilk avatar Dec 10 '21 19:12 tilk

I see. That's a bit disappointing, but I understand the reasons. Thanks for responding.

I do think it would be helpful to explain this in the README and the F-droid description to help set expectations for users.

QEDan avatar Dec 10 '21 19:12 QEDan

I know it's been ages but I would be delighted if you can test my very alpha support for just that! https://github.com/yassineim/cdlc_player/releases/tag/audio-v4

Also raised a PR which I hope will get merged despite the prebuilt *.so, the thing being that building those blobs is a big headache to document, not that it's hard or anything, just tedious.

ghost avatar Apr 08 '23 09:04 ghost

@yassineim It works! Thank you so much for adding that. I will report any problems I encounter.

QEDan avatar Apr 08 '23 15:04 QEDan

@QEDan @tilk

I added a lot of improvements that reflect both to performance and the resulting apk size. I hope you can check.

https://github.com/yassineim/cdlc_player/releases/tag/audio-v4

ghost avatar Apr 10 '23 12:04 ghost

Will the audio-playing version be added to F-Droid?

sanicki avatar Jan 06 '24 20:01 sanicki