Randall Leeds comments

Results 377 comments of


                                            Randall Leeds

Adding ASGI support?

I'd like first-class ASGI support, whether that means adding extras dependencies in Gunicorn, a stub worker that tells you what to install, documentation, or something else.

Adding ASGI support?

@japrogramer http://www.uvicorn.org/#running-with-gunicorn

`reload_extra_files` should accept wildcards

Since I don't see a compelling reason not to support this, I'd review a PR.

root config doesn't allow Document

I think what could be done here is to use the `ParentNode` interface, instead. That's the common interface that defines `querySelector`. Then, a short-circuit when attempting to find the node...

fix: use up-to-date `kid` in JWT header when refreshing

Not sure if there's anything I should do about the CodeQL scanning results task failing. It seems spurious.

fix: use up-to-date `kid` in JWT header when refreshing

I pushed up three commits to restore the `extra` key, validate the UUID format, and remove some of the extraneous diff.

fix: use up-to-date `kid` in JWT header when refreshing

Also, please let me know how you'd like me to resolve conflicts, if at all. I can merge or rebase or squash at your preference.

fix: use up-to-date `kid` in JWT header when refreshing

I realized the checks wouldn't even run due to the conflict, so I rebased and squashed.

fix: use up-to-date `kid` in JWT header when refreshing

And, I think the CI jobs flaked, but I can't re-run them. 😞

fix: use up-to-date `kid` in JWT header when refreshing

@aeneasr anything more I can do here?