mapbox-vector-tile icon indicating copy to clipboard operation
mapbox-vector-tile copied to clipboard

Updates of the repository

Open benoit9126 opened this issue 3 years ago • 2 comments

Hi,

Here is a large proposal to update this Python package. It contains

  1. The drop of Python 2 support
  2. A more recent generation of the protobuf Python code to solve #113
  3. The usage of GitHub actions
  4. The usage of Poetry with a pyproject.toml
  5. The usage of pre-commit (black, isort, flake8, etc)
  6. The usage of tox for the tests.

benoit9126 avatar Aug 22 '22 16:08 benoit9126

@benoit9126 I'm not the repo owner or maintainer but IMO you should split this PR in multiple small PR and first discuss change in issue (e.g usage of poetry), it might ease the reviewer and increase the likelihood of the fix to be merged :-)

vincentsarago avatar Aug 22 '22 19:08 vincentsarago

Ok. Do you have a priority order among the points listed above?

benoit9126 avatar Aug 23 '22 06:08 benoit9126

Ok. Do you have a priority order among the points listed above?

my 2c is dropping python2 support and protobuf generation are higher priority.

rmarianski avatar Dec 15 '22 03:12 rmarianski

@rmarianski : The next possible steps would be:

  1. A more recent generation of the protobuf Python code to solve #113
  2. The usage of Poetry with a pyproject.toml
  3. The usage of pre-commit (black, isort, flake8, etc)

I start to implement the first which is the most important for me. If the community aggrees with the two other proposals, I can provide them too.

benoit9126 avatar Dec 20 '22 09:12 benoit9126

  1. I also note that there are some troubles between the round function of Python 2 and 3 that forces you to use quantize and to pass a round function in some operators (encode for instance). As now, only Python 3 is supported, we could remove this argument round_fn and just use the round function.

benoit9126 avatar Dec 20 '22 11:12 benoit9126

@rmarianski I close this PR as everything was added in other PR.

benoit9126 avatar Jan 02 '23 13:01 benoit9126