mapbox-vector-tile
mapbox-vector-tile copied to clipboard
Updates of the repository
Hi,
Here is a large proposal to update this Python package. It contains
- The drop of Python 2 support
- A more recent generation of the
protobufPython code to solve #113 - The usage of GitHub actions
- The usage of
Poetrywith apyproject.toml - The usage of
pre-commit(black,isort,flake8, etc) - The usage of
toxfor the tests.
@benoit9126 I'm not the repo owner or maintainer but IMO you should split this PR in multiple small PR and first discuss change in issue (e.g usage of poetry), it might ease the reviewer and increase the likelihood of the fix to be merged :-)
Ok. Do you have a priority order among the points listed above?
Ok. Do you have a priority order among the points listed above?
my 2c is dropping python2 support and protobuf generation are higher priority.
@rmarianski : The next possible steps would be:
- A more recent generation of the
protobufPython code to solve #113 - The usage of
Poetrywith apyproject.toml - The usage of pre-commit (black, isort, flake8, etc)
I start to implement the first which is the most important for me. If the community aggrees with the two other proposals, I can provide them too.
- I also note that there are some troubles between the
roundfunction of Python 2 and 3 that forces you to usequantizeand to pass a round function in some operators (encodefor instance). As now, only Python 3 is supported, we could remove this argumentround_fnand just use the round function.
@rmarianski I close this PR as everything was added in other PR.