tilemill icon indicating copy to clipboard operation
tilemill copied to clipboard

pkg-config protobuf --version needs to be pkg-config protobuf --nodversion

Open dreirund opened this issue 5 years ago • 1 comments

Describe the bug ./configure.js spills out

[...]
[tilemill configure] Could not configure TileMill because "pkg-config protobuf --version" returned an error (pkgconf: --version specified with other options or module names, assuming --modversion.)

This does come from a run of pkg-config protobuf --version:

pkgconf: --version specified with other options or module names, assuming --modversion.
3.7.0

Instead, pkg-config protobuf --modversion should be executed:

3.7.0

Environment: (Note: We are not setup to test on Linux or Windows so help may be slower on those OSs)

  • OS & Version: Arch/ Artix Linux
  • Node Version [e.g. v8.15.0] node --version: v11.15.0

To Reproduce

  • git clone git://github.com/tilemill-project/tilemill.git
  • cd tilemill
  • ./configure.js

Expected behavior ./configure.js finishes without error messages.

dreirund avatar May 15 '19 08:05 dreirund

Patch attached.

AND: Please configure your issue tracker to support .patch and .diff-files as well. You make it unneededly complicated for users to hand in patches ... (who does not use git but uses the "classic" ways ...)

configure-js.protobuf.fix-versionargument.patch.txt

dreirund avatar May 15 '19 08:05 dreirund