tilelang icon indicating copy to clipboard operation
tilelang copied to clipboard

[Question] `func_or_mod.__name__` in MetalKernelAdapter

Open kurisu6912 opened this issue 2 months ago • 2 comments

Required prerequisites

Questions

While func_or_mod is tir.PrimFunc | tvm.IRModule, why accessing __name__ of it? The name of function should inside its attrs

https://github.com/tile-ai/tilelang/blob/6e1dc6a135edfdf35d43fbca623ec65176eef6fe/tilelang/jit/adapter/torch/metal.py#L16-L31

kurisu6912 avatar Oct 27 '25 10:10 kurisu6912

would you mind take a look @oraluben ?

LeiWang1999 avatar Oct 29 '25 04:10 LeiWang1999

@kurisu6912 You're probably right. I'm not familiar with tvm apis so just make it work here. Are there some examples about this part?

The name of function should inside its attrs

Update: I saw your PR has changed this part, there's no special reason about this, the change LGTM.

oraluben avatar Oct 29 '25 06:10 oraluben

fixed in #1120

kurisu6912 avatar Nov 03 '25 05:11 kurisu6912