tilelang
tilelang copied to clipboard
[Question] `func_or_mod.__name__` in MetalKernelAdapter
Required prerequisites
- [x] I have read the documentation https://tilelang.com.
- [x] I have searched the Issue Tracker that this hasn't already been reported. (comment there if it has.)
Questions
While func_or_mod is tir.PrimFunc | tvm.IRModule, why accessing __name__ of it? The name of function should inside its attrs
https://github.com/tile-ai/tilelang/blob/6e1dc6a135edfdf35d43fbca623ec65176eef6fe/tilelang/jit/adapter/torch/metal.py#L16-L31
would you mind take a look @oraluben ?
@kurisu6912 You're probably right. I'm not familiar with tvm apis so just make it work here. Are there some examples about this part?
The name of function should inside its attrs
Update: I saw your PR has changed this part, there's no special reason about this, the change LGTM.
fixed in #1120