router.js icon indicating copy to clipboard operation
router.js copied to clipboard

Expose RouterJS' TypeScript types publicly

Open theseyi opened this issue 6 years ago • 2 comments

The types for public interfaces should be exposed publicly to users who want to consume the types in their application, e.g. EmberJS users.

For example, the Ember Router class method didTransition has parameters that are passed in on invocation https://github.com/tildeio/router.js/blob/73d6a7f5ca6fba3cfff8460245fb5a3ceef8a2b5/lib/router/handler-info.ts#L324

These types are not defined in the Ember JS typings and it's currently not easy to just install and import the router_js types EDIT: #238 seems like it be related to the issues encountered with importing

theseyi avatar Sep 10 '18 18:09 theseyi

Any interest in resolving this issue?

theseyi avatar Dec 06 '18 23:12 theseyi

yes! :)

Bnaya avatar Dec 15 '18 08:12 Bnaya