titan icon indicating copy to clipboard operation
titan copied to clipboard

Published 20 hours ago • verified publisher icon tikv

RocksDB makes sure the order of notifying OnFlushCompleted and OnCompactionCompleted

Open Connor1996 opened this issue 4 years ago • 2 comments

In this PR https://github.com/facebook/rocksdb/pull/6342, it fixes the issue that OnFlushCompleted and OnCompactionCompleted are called out of order which is the root cause of what #172 fixes.

After it is merged into our branch, we can remove the extra logic in Titan

Connor1996 avatar Jul 06 '20 15:07 Connor1996

Sadly that PR was abandoned..

yiwu-arbug avatar Jul 06 '20 23:07 yiwu-arbug

@yiwu-arbug oh, didn't notice that it is closed. I was though it is merged

Connor1996 avatar Jul 07 '20 01:07 Connor1996