tikv icon indicating copy to clipboard operation
tikv copied to clipboard

rocksdb: Expose track-and-verify-wals-in-manifest config

Open v01dstar opened this issue 1 year ago • 1 comments

What is changed and how it works?

Issue Number: Ref #16549

What's Changed:

Expose track-and-verify-wals-in-manifest config.

For further investigating corrupted WAL issue happened during EBS restore process.

Related changes

  • [ ] PR to update pingcap/docs/pingcap/docs-cn:
  • [ ] Need to cherry-pick to the release branch

Check List

Tests

  • [x] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Release note

None

v01dstar avatar Feb 21 '24 00:02 v01dstar

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Feb 21 '24 00:02 ti-chi-bot[bot]

/merge

Connor1996 avatar Feb 28 '24 07:02 Connor1996

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot[bot] avatar Feb 28 '24 07:02 ti-chi-bot[bot]

This pull request has been accepted and is ready to merge.

Commit hash: a2b0630737a5d082269523c0648e7d5523e8d847

ti-chi-bot[bot] avatar Feb 28 '24 07:02 ti-chi-bot[bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #16574.

ti-chi-bot avatar Feb 28 '24 07:02 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.5: #16575.

ti-chi-bot avatar Feb 28 '24 07:02 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.1: #16806.

ti-chi-bot avatar Apr 11 '24 06:04 ti-chi-bot