tikv icon indicating copy to clipboard operation
tikv copied to clipboard

raftstore: Introduce witness peer

Open Connor1996 opened this issue 3 years ago • 3 comments

Signed-off-by: Connor1996 [email protected]

What is changed and how it works?

Issue Number: Ref https://github.com/tikv/tikv/issues/12876

What's Changed:

Introduce witness peer

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Breaking backward compatibility

Release note

Introduce witness peer

Connor1996 avatar Jul 06 '22 11:07 Connor1996

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay
  • ethercflow

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Jul 06 '22 11:07 ti-chi-bot

More tests are on the way, you can review the overall process first. @BusyJay @ethercflow

Connor1996 avatar Sep 05 '22 12:09 Connor1996

PTAL @BusyJay

Connor1996 avatar Nov 03 '22 03:11 Connor1996

After discussion, the raft log gc logic is renewed for witness. Remove it from this PR, would add it in the next PR.

Connor1996 avatar Nov 07 '22 08:11 Connor1996

/merge

Connor1996 avatar Nov 09 '22 08:11 Connor1996

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Nov 09 '22 08:11 ti-chi-bot

This pull request has been accepted and is ready to merge.

Commit hash: ac24747564c106e3d7bec186fb3f2977430a6384

ti-chi-bot avatar Nov 09 '22 08:11 ti-chi-bot