tikv icon indicating copy to clipboard operation
tikv copied to clipboard

Observer: add some metrics for the waiting queue of snapshot generator.

Open bufferflies opened this issue 3 years ago • 2 comments

What is changed and how it works?

Issue Number: Close #12945

What's Changed:

Related changes

Check List

Tests

  • Manual test (add detailed scripts or steps below) image

Side effects

Release note

None.

bufferflies avatar Jun 30 '22 12:06 bufferflies

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Jun 30 '22 12:06 ti-chi-bot

/cc @lhy1024 @AndreMouche

bufferflies avatar Aug 24 '22 07:08 bufferflies

PTAL @AndreMouche again

bufferflies avatar Sep 01 '22 09:09 bufferflies

PTAL @Connor1996

bufferflies avatar Sep 05 '22 09:09 bufferflies

/ping @nolouch

bufferflies avatar Sep 20 '22 03:09 bufferflies

/ping @Connor1996 , help me merge it

bufferflies avatar Sep 23 '22 03:09 bufferflies

/merge

AndreMouche avatar Sep 23 '22 03:09 AndreMouche

@AndreMouche: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Sep 23 '22 03:09 ti-chi-bot

This pull request has been accepted and is ready to merge.

Commit hash: d796d15f28596922b42a6319d64daa6503c167a1

ti-chi-bot avatar Sep 23 '22 03:09 ti-chi-bot

@bufferflies: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Sep 23 '22 07:09 ti-chi-bot