rust-rocksdb icon indicating copy to clipboard operation
rust-rocksdb copied to clipboard
verified publisher icon tikv

Use rocksdb SyncPoint to support fail-rs

Open yiwu-arbug opened this issue 6 years ago • 5 comments

To allow integration test frameworks to control rocksdb internals, we can make use of rocksdb SyncPoint to support rust fail-point https://github.com/tikv/fail-rs There are some difference between SyncPoint and fail-point. Some of the items to work on:

  • [ ] Make fail-point support dependencies (one fail-point wait for another before proceed)
  • [ ] Make SyncPoint support early return
  • [ ] Add rocksdb compile flag to enable SyncPoint in release build
  • [ ] Expose SyncPoint API on rocksdb side, then wrap it as fail-point API on rust-rocksdb side

yiwu-arbug avatar Oct 25 '19 03:10 yiwu-arbug

cc @Connor1996

yiwu-arbug avatar Oct 25 '19 03:10 yiwu-arbug

Very useful!

Connor1996 avatar Oct 25 '19 05:10 Connor1996

I would like to take this task, and choose the exposing syncpoint's API part

Sullivan12138 avatar Nov 25 '19 07:11 Sullivan12138

https://github.com/facebook/rocksdb/issues/6087

yiwu-arbug avatar Nov 25 '19 21:11 yiwu-arbug

Sorry, there's another task that invite me to do, so I may have to quit

Sullivan12138 avatar Nov 29 '19 08:11 Sullivan12138