rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard
verified publisher icon tikv

compaction: add a new option 'bottom_level_check_range_overlap' for manual compact

Open glorv opened this issue 4 months ago • 2 comments

  • The new option bottom_level_check_range_overlap is used for manual compact to ensure the SST file in the bottom level with a huge range can be force partitioned with manual compaction.
  • Also add a few log for the SST ingest level selection to make it easier to investigate unexpected SST ingestion level.

glorv avatar Aug 19 '25 07:08 glorv

/hold

glorv avatar Aug 20 '25 03:08 glorv

@v01dstar @Connor1996 PTAL again. Originally, I decided to rely on CanDoTrivialMove in SSTPartitioner to handle this, but it turns on this can't fully resolve the problem. Because CanDoTrivialMove applies to all levels, so it's likely to trigger false-positive ManualCompact because the range overlaps with l0 ssts ranges but there is actually no data overlap.

glorv avatar Nov 17 '25 08:11 glorv

/unhold

glorv avatar Nov 18 '25 02:11 glorv

@hhwyt: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Nov 18 '25 05:11 ti-chi-bot[bot]

/hold

glorv avatar Nov 18 '25 05:11 glorv

/unhold

glorv avatar Nov 18 '25 05:11 glorv

/retest

glorv avatar Nov 18 '25 06:11 glorv

/run-test

glorv avatar Nov 18 '25 06:11 glorv

[LGTM Timeline notifier]

Timeline:

  • 2025-11-18 03:12:45.142904941 +0000 UTC m=+1363014.585934810: :ballot_box_with_check: agreed by hhwyt.
  • 2025-11-18 05:17:51.901306892 +0000 UTC m=+1370521.344336771: :ballot_box_with_check: agreed by hbisheng.
  • 2025-11-18 05:22:51.632543955 +0000 UTC m=+1370821.075573834: :heavy_multiplication_x::repeat: reset by glorv.
  • 2025-11-18 05:23:44.183958266 +0000 UTC m=+1370873.626988144: :ballot_box_with_check: agreed by hbisheng.
  • 2025-11-18 05:24:19.494582602 +0000 UTC m=+1370908.937612471: :ballot_box_with_check: agreed by hhwyt.
  • 2025-11-18 05:28:08.621903617 +0000 UTC m=+1371138.064933506: :heavy_multiplication_x::repeat: reset by glorv.
  • 2025-11-18 06:31:05.371275693 +0000 UTC m=+1374914.814305572: :ballot_box_with_check: agreed by v01dstar.
  • 2025-11-18 08:12:35.155982861 +0000 UTC m=+1381004.599012730: :ballot_box_with_check: agreed by hhwyt.

ti-chi-bot[bot] avatar Nov 18 '25 08:11 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, hhwyt, v01dstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 18 '25 08:11 ti-chi-bot[bot]