rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Move `SaveTo` out of mutex

Open Connor1996 opened this issue 4 months ago • 1 comments

Previously #417 PR reverts this change for simplicity. But the performance result isn't good enough.

The reason for mutex wrapping SaveTo is to update the file ref count. This PR make the ref count atomic, so we can move SaveTo out of mutex.

image

Connor1996 avatar Aug 12 '25 22:08 Connor1996

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign crazycs520 for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Aug 12 '25 23:08 ti-chi-bot[bot]