rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Process high pri request with mutex in rate limiter

Open v01dstar opened this issue 1 year ago • 3 comments

The existing code has concurrency problem. Some of the fields should be processed with lock held.

v01dstar avatar Sep 24 '24 06:09 v01dstar

/lgtm

refresh

wuhuizuo avatar Sep 24 '24 07:09 wuhuizuo

@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Sep 24 '24 07:09 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wuhuizuo Once this PR has been reviewed and has the lgtm label, please assign spadea-tang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 24 '24 07:09 ti-chi-bot[bot]

I tested this change with benchbot, no regression.

v01dstar avatar Sep 27 '24 03:09 v01dstar