pd icon indicating copy to clipboard operation
pd copied to clipboard

statistics: Add 'store' label to metric pd_cluster_status.

Open SerjKol80 opened this issue 1 month ago • 3 comments

What problem does this PR solve?

Issue Number: Close #9855

What is changed and how does it work?

Add 'store' label to metric pd_cluster_status.

Check List

Tests

  • Unit test

Code changes

  • Metrics only

Side effects

  • metric pd_cluster_status now needs to be aggregated in metic system across all stores if you need value across whole cluster.

Related changes N/A

Release note

metric "pd_cluster_status" now has additional label "store" containing ID of the store.

SerjKol80 avatar Oct 31 '25 19:10 SerjKol80

Hi @SerjKol80. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Oct 31 '25 19:10 ti-chi-bot[bot]

/ok-to-test

rleungx avatar Nov 03 '25 05:11 rleungx

@lhy1024 Thank you. Would you initiate the merge. It looks like I don't have permission.

SerjKol80 avatar Nov 05 '25 19:11 SerjKol80

@bufferflies PTAL

lhy1024 avatar Nov 06 '25 02:11 lhy1024

[LGTM Timeline notifier]

Timeline:

  • 2025-11-05 07:29:51.714334856 +0000 UTC m=+255241.157364725: :ballot_box_with_check: agreed by lhy1024.
  • 2025-11-11 23:30:21.105077587 +0000 UTC m=+831270.548107466: :ballot_box_with_check: agreed by Tema.

ti-chi-bot[bot] avatar Nov 11 '25 23:11 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, lhy1024, Tema

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [bufferflies,lhy1024]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 12 '25 01:11 ti-chi-bot[bot]

@lhy1024 @bufferflies could you please approve 4 pending workflows to run ^

Tema avatar Nov 12 '25 17:11 Tema

/retest

SerjKol80 avatar Nov 12 '25 20:11 SerjKol80

Codecov Report

:x: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 78.68%. Comparing base (75bdf39) to head (fc8d6df). :warning: Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9898      +/-   ##
==========================================
+ Coverage   78.58%   78.68%   +0.10%     
==========================================
  Files         494      495       +1     
  Lines       66411    66457      +46     
==========================================
+ Hits        52187    52294     +107     
+ Misses      10440    10379      -61     
  Partials     3784     3784              
Flag Coverage Δ
unittests 78.68% <95.91%> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 12 '25 20:11 codecov[bot]

/retest

SerjKol80 avatar Nov 12 '25 21:11 SerjKol80

/test pull-unit-test-next-gen

lhy1024 avatar Nov 13 '25 03:11 lhy1024

/retest

SerjKol80 avatar Nov 13 '25 18:11 SerjKol80

/retest

SerjKol80 avatar Nov 13 '25 20:11 SerjKol80

In response to a cherrypick label: new pull request created to branch release-8.5: #10055. But this PR has conflicts, please resolve them!

ti-chi-bot avatar Dec 12 '25 03:12 ti-chi-bot