statistics: Add 'store' label to metric pd_cluster_status.
What problem does this PR solve?
Issue Number: Close #9855
What is changed and how does it work?
Check List
Tests
- Unit test
Code changes
- Metrics only
Side effects
- metric pd_cluster_status now needs to be aggregated in metic system across all stores if you need value across whole cluster.
Related changes N/A
Release note
metric "pd_cluster_status" now has additional label "store" containing ID of the store.
Hi @SerjKol80. Thanks for your PR.
I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test
@lhy1024 Thank you. Would you initiate the merge. It looks like I don't have permission.
@bufferflies PTAL
[LGTM Timeline notifier]
Timeline:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bufferflies, lhy1024, Tema
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [bufferflies,lhy1024]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@lhy1024 @bufferflies could you please approve 4 pending workflows to run ^
/retest
Codecov Report
:x: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 78.68%. Comparing base (75bdf39) to head (fc8d6df).
:warning: Report is 43 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #9898 +/- ##
==========================================
+ Coverage 78.58% 78.68% +0.10%
==========================================
Files 494 495 +1
Lines 66411 66457 +46
==========================================
+ Hits 52187 52294 +107
+ Misses 10440 10379 -61
Partials 3784 3784
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 78.68% <95.91%> (+0.10%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/retest
/test pull-unit-test-next-gen
/retest
/retest
In response to a cherrypick label: new pull request created to branch release-8.5: #10055.
But this PR has conflicts, please resolve them!