pd icon indicating copy to clipboard operation
pd copied to clipboard

tso: fix tso client fallback group

Open ystaticy opened this issue 1 month ago • 8 comments

What problem does this PR solve?

Issue Number: Close https://github.com/tikv/pd/issues/9883

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

ystaticy avatar Oct 28 '25 08:10 ystaticy

Hi @ystaticy. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Oct 28 '25 08:10 ti-chi-bot[bot]

/ok-to-test

JmPotato avatar Oct 28 '25 08:10 JmPotato

/retest

ystaticy avatar Oct 28 '25 10:10 ystaticy

/retest

ystaticy avatar Oct 28 '25 11:10 ystaticy

/retest

ystaticy avatar Oct 28 '25 13:10 ystaticy

Codecov Report

:x: Patch coverage is 84.61538% with 10 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 78.47%. Comparing base (06ae8ba) to head (382c7e1). :warning: Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9882      +/-   ##
==========================================
+ Coverage   78.44%   78.47%   +0.02%     
==========================================
  Files         503      503              
  Lines       67176    67270      +94     
==========================================
+ Hits        52699    52787      +88     
+ Misses      10653    10643      -10     
- Partials     3824     3840      +16     
Flag Coverage Δ
unittests 78.47% <84.61%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 28 '25 13:10 codecov[bot]

/retest

ystaticy avatar Nov 07 '25 12:11 ystaticy

/retest

ystaticy avatar Nov 10 '25 02:11 ystaticy

CI failed.

rleungx avatar Nov 10 '25 03:11 rleungx

/retest

ystaticy avatar Nov 10 '25 05:11 ystaticy

/retest

ystaticy avatar Nov 10 '25 07:11 ystaticy

/retest

ystaticy avatar Nov 10 '25 07:11 ystaticy

/retest

ystaticy avatar Nov 23 '25 06:11 ystaticy

/retest

ystaticy avatar Nov 23 '25 14:11 ystaticy

/retest

ystaticy avatar Nov 28 '25 09:11 ystaticy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 02 '25 07:12 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-11-04 08:58:16.669041892 +0000 UTC m=+174146.112071761: :ballot_box_with_check: agreed by bufferflies.
  • 2025-12-02 07:23:51.66636346 +0000 UTC m=+334576.480141042: :ballot_box_with_check: agreed by rleungx.

ti-chi-bot[bot] avatar Dec 02 '25 07:12 ti-chi-bot[bot]