pd icon indicating copy to clipboard operation
pd copied to clipboard

client: updating keyspace group must check the previous version

Open bufferflies opened this issue 2 months ago • 3 comments

What problem does this PR solve?

Issue Number: Close #6770

kv proto: #1361

What is changed and how does it work?

'FindGroupByKeyspaceID' must carry the current keyspace group version, and the server needs to check the memory
state isn't stale, and then return the server keyspace group info.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

bufferflies avatar Oct 22 '25 07:10 bufferflies

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot[bot] avatar Oct 22 '25 07:10 ti-chi-bot[bot]

/ping @rleungx @JmPotato @ystaticy

bufferflies avatar Nov 13 '25 06:11 bufferflies

@ystaticy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Nov 14 '25 03:11 ti-chi-bot[bot]

/ping @rleungx PTAL again

bufferflies avatar Nov 19 '25 01:11 bufferflies

Codecov Report

:x: Patch coverage is 76.71233% with 17 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 78.45%. Comparing base (d9219d5) to head (a709f84). :warning: Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9862      +/-   ##
==========================================
- Coverage   78.70%   78.45%   -0.25%     
==========================================
  Files         492      503      +11     
  Lines       66268    67176     +908     
==========================================
+ Hits        52153    52706     +553     
- Misses      10408    10640     +232     
- Partials     3707     3830     +123     
Flag Coverage Δ
unittests 78.45% <76.71%> (-0.25%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 20 '25 14:11 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx, ystaticy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 27 '25 07:11 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-11-26 05:11:32.909648438 +0000 UTC m=+679656.558842905: :ballot_box_with_check: agreed by rleungx.
  • 2025-11-27 07:54:33.817140933 +0000 UTC m=+775837.466335390: :ballot_box_with_check: agreed by okJiang.

ti-chi-bot[bot] avatar Nov 27 '25 07:11 ti-chi-bot[bot]

/retest

bufferflies avatar Nov 28 '25 03:11 bufferflies

/test pull-unit-test-next-gen

bufferflies avatar Nov 28 '25 04:11 bufferflies

/test pull-unit-test-next-gen

bufferflies avatar Nov 28 '25 07:11 bufferflies