client: updating keyspace group must check the previous version
What problem does this PR solve?
Issue Number: Close #6770
kv proto: #1361
What is changed and how does it work?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Code changes
Side effects
Related changes
- Need to cherry-pick to the release branch
Release note
None.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/ping @rleungx @JmPotato @ystaticy
@ystaticy: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ping @rleungx PTAL again
Codecov Report
:x: Patch coverage is 76.71233% with 17 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 78.45%. Comparing base (d9219d5) to head (a709f84).
:warning: Report is 24 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #9862 +/- ##
==========================================
- Coverage 78.70% 78.45% -0.25%
==========================================
Files 492 503 +11
Lines 66268 67176 +908
==========================================
+ Hits 52153 52706 +553
- Misses 10408 10640 +232
- Partials 3707 3830 +123
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 78.45% <76.71%> (-0.25%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: okJiang, rleungx, ystaticy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [rleungx]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
/retest
/test pull-unit-test-next-gen
/test pull-unit-test-next-gen