pd icon indicating copy to clipboard operation
pd copied to clipboard

Unsafe Recovery: Add tombstoned tiflash learners into DemoteFailedVoters (#9554)

Open ti-chi-bot opened this issue 2 months ago • 3 comments

This is an automated cherry-pick of #9554

What problem does this PR solve?

Issue Number: Close #9624

What is changed and how does it work?

Remove tombtstoned TiFlash learners in DemoteFailedVoters phase

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

ti-chi-bot avatar Oct 14 '25 21:10 ti-chi-bot

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Oct 14 '25 21:10 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign huachaohuang for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Oct 14 '25 21:10 ti-chi-bot[bot]

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-build-release-8.1 6c608db95b77f5e3a2deaf266c57e175dc04f65d link true /test pull-build-release-8.1

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Oct 14 '25 21:10 ti-chi-bot[bot]