Unsafe Recovery: Add tombstoned tiflash learners into DemoteFailedVoters (#9554)
This is an automated cherry-pick of #9554
What problem does this PR solve?
Issue Number: Close #9624
What is changed and how does it work?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Code changes
- Has the configuration change
- Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
- Has persistent data change
Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
Related changes
- PR to update
pingcap/docs/pingcap/docs-cn: - PR to update
pingcap/tiup: - Need to cherry-pick to the release branch
Release note
None.
/retest
/test all
/retest-required
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 77.67%. Comparing base (0557634) to head (893b755).
:warning: Report is 5 commits behind head on release-8.5.
Additional details and impacted files
@@ Coverage Diff @@
## release-8.5 #9830 +/- ##
===============================================
+ Coverage 75.87% 77.67% +1.80%
===============================================
Files 467 467
Lines 73920 62369 -11551
===============================================
- Hits 56088 48448 -7640
+ Misses 14272 10347 -3925
- Partials 3560 3574 +14
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 77.67% <100.00%> (+1.80%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JmPotato, nolouch
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JmPotato,nolouch]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment