pd icon indicating copy to clipboard operation
pd copied to clipboard

Unsafe Recovery: Add tombstoned tiflash learners into DemoteFailedVoters (#9554)

Open ti-chi-bot opened this issue 2 months ago • 2 comments

This is an automated cherry-pick of #9554

What problem does this PR solve?

Issue Number: Close #9624

What is changed and how does it work?

Remove tombtstoned TiFlash learners in DemoteFailedVoters phase

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

ti-chi-bot avatar Oct 14 '25 21:10 ti-chi-bot

/retest

v01dstar avatar Dec 02 '25 19:12 v01dstar

/test all

v01dstar avatar Dec 02 '25 19:12 v01dstar

/retest-required

v01dstar avatar Dec 02 '25 19:12 v01dstar

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 77.67%. Comparing base (0557634) to head (893b755). :warning: Report is 5 commits behind head on release-8.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.5    #9830      +/-   ##
===============================================
+ Coverage        75.87%   77.67%   +1.80%     
===============================================
  Files              467      467              
  Lines            73920    62369   -11551     
===============================================
- Hits             56088    48448    -7640     
+ Misses           14272    10347    -3925     
- Partials          3560     3574      +14     
Flag Coverage Δ
unittests 77.67% <100.00%> (+1.80%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 02 '25 22:12 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [JmPotato,nolouch]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 03 '25 06:12 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-12-02 22:59:56.633732544 +0000 UTC m=+390741.447510106: :ballot_box_with_check: agreed by nolouch.
  • 2025-12-03 06:24:33.811263609 +0000 UTC m=+417418.625041171: :ballot_box_with_check: agreed by JmPotato.

ti-chi-bot[bot] avatar Dec 03 '25 06:12 ti-chi-bot[bot]