pd icon indicating copy to clipboard operation
pd copied to clipboard

resource_group: replace LoadResourceGroups with GetResourceGroupsMeta…

Open disksing opened this issue 8 months ago • 3 comments

…Revision

What problem does this PR solve?

Issue Number: Close #9272

What is changed and how does it work?

  • change the method to GetResourceGroupsMetaRevision which only returns meta revision.
  • add CountOnly option to allow only return kv count

Check List

Tests

  • Unit test

Related changes merge after https://github.com/pingcap/kvproto/pull/1309

Release note

None.

disksing avatar Apr 28 '25 04:04 disksing

Codecov Report

:x: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.09%. Comparing base (873ea1e) to head (11924d5). :warning: Report is 279 commits behind head on master.

:x: Your patch check has failed because the patch coverage (65.38%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9273      +/-   ##
==========================================
+ Coverage   76.05%   76.09%   +0.03%     
==========================================
  Files         470      472       +2     
  Lines       73051    73061      +10     
==========================================
+ Hits        55562    55597      +35     
+ Misses      14045    14027      -18     
+ Partials     3444     3437       -7     
Flag Coverage Δ
unittests 76.09% <65.38%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 28 '25 06:04 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 28 '25 07:04 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-04-28 07:11:22.073969861 +0000 UTC m=+858025.885760242: :ballot_box_with_check: agreed by nolouch.

ti-chi-bot[bot] avatar Apr 28 '25 07:04 ti-chi-bot[bot]

@disksing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-next-gen-1 11924d5133c2404c39eb8035d657212a9b5a4367 link true /test pull-unit-test-next-gen-1
pull-unit-test-next-gen-2 11924d5133c2404c39eb8035d657212a9b5a4367 link true /test pull-unit-test-next-gen-2
pull-unit-test-next-gen-3 11924d5133c2404c39eb8035d657212a9b5a4367 link true /test pull-unit-test-next-gen-3

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Dec 04 '25 10:12 ti-chi-bot[bot]