pd icon indicating copy to clipboard operation
pd copied to clipboard

scheduler: add new api to add a new job for the special scheduler

Open bufferflies opened this issue 9 months ago • 3 comments

What problem does this PR solve?

Issue Number: Close #9161

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

bufferflies avatar Mar 21 '25 03:03 bufferflies

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot[bot] avatar Mar 21 '25 03:03 ti-chi-bot[bot]

Codecov Report

Attention: Patch coverage is 56.82657% with 117 lines in your changes missing coverage. Please review.

Project coverage is 76.02%. Comparing base (d11f535) to head (f2aa0fb). Report is 1 commits behind head on master.

:x: Your patch status has failed because the patch coverage (56.82%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9162      +/-   ##
==========================================
+ Coverage   75.97%   76.02%   +0.05%     
==========================================
  Files         472      472              
  Lines       73045    73249     +204     
==========================================
+ Hits        55497    55690     +193     
- Misses      14100    14104       +4     
- Partials     3448     3455       +7     
Flag Coverage Δ
unittests 76.02% <56.82%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 02 '25 03:04 codecov[bot]

/test

bufferflies avatar Apr 09 '25 06:04 bufferflies

@bufferflies: The /test command needs one or more targets. The following commands are available to trigger required jobs:

/test build
/test pull-integration-realcluster-test

The following commands are available to trigger optional jobs:

/debug pull-unit-test
/test pull-integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/ghpr_build
tikv/pd/pull_integration_realcluster_test

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Apr 09 '25 06:04 ti-chi-bot[bot]

/retest

bufferflies avatar Apr 25 '25 01:04 bufferflies

/ping @nolouch @okJiang

bufferflies avatar Apr 28 '25 07:04 bufferflies

[LGTM Timeline notifier]

Timeline:

  • 2025-04-28 12:12:12.540483898 +0000 UTC m=+876076.352274272: :ballot_box_with_check: agreed by lhy1024.
  • 2025-04-29 07:52:19.282380931 +0000 UTC m=+946883.094171312: :ballot_box_with_check: agreed by okJiang.

ti-chi-bot[bot] avatar Apr 29 '25 07:04 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [lhy1024,nolouch]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 29 '25 08:04 ti-chi-bot[bot]