pd
pd copied to clipboard
tikv
gc: Implement compatibility methods and `GetAllKeyspacesGCStates` method to `GCStateManager`
What problem does this PR solve?
Issue Number: Ref #8978
What is changed and how does it work?
Blocked by:
- ~~https://github.com/tikv/pd/pull/9109~~
- https://github.com/tikv/pd/pull/9169
~~This PR is branched from #9109 which is not merged yet. If you want to view the diff in this PR without being disturbed by changes from #9109, please see: https://github.com/MyonKeminta/pd/compare/m/gc-state-storage...MyonKeminta:pd:m/gc-state-manager~~
Part of this PR is split out to https://github.com/tikv/pd/pull/9169 . Please merge #9169 first. To see changes in this PR based on #9169, see: https://github.com/MyonKeminta/pd/compare/m/gc-state-manager-partial...MyonKeminta:pd:m/gc-state-manager
Check List
Tests
- Unit test
Code changes
Side effects
- Possible performance regression
- Increased code complexity
Related changes
Release note
None.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Attention: Patch coverage is 78.00000% with 33 lines in your changes missing coverage. Please review.
Project coverage is 75.87%. Comparing base (
c22da0f) to head (b2e74cf). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #9134 +/- ##
==========================================
+ Coverage 75.80% 75.87% +0.06%
==========================================
Files 477 477
Lines 73532 73679 +147
==========================================
+ Hits 55743 55901 +158
+ Misses 14304 14295 -9
+ Partials 3485 3483 -2
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 75.87% <78.00%> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JmPotato, rleungx
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JmPotato,rleungx]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment