pd
pd copied to clipboard
*: reset config if the input is invalid (#8632)
This is an automated cherry-pick of #8632
What problem does this PR solve?
Issue Number: Close #8619.
What is changed and how does it work?
Check List
Tests
- Unit test
Release note
None.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.
Project coverage is 75.56%. Comparing base (
959b578) to head (1a4fa89). Report is 6 commits behind head on release-6.5.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| server/schedulers/grant_leader.go | 22.22% | 6 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## release-6.5 #8661 +/- ##
===============================================
- Coverage 75.64% 75.56% -0.08%
===============================================
Files 332 332
Lines 33855 33869 +14
===============================================
- Hits 25608 25592 -16
- Misses 6049 6068 +19
- Partials 2198 2209 +11
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 75.56% <63.15%> (-0.08%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[LGTM Timeline notifier]
Timeline:
2024-09-25 05:57:56.855760773 +0000 UTC m=+1631946.596184706: :ballot_box_with_check: agreed by lhy1024.2025-02-05 04:02:46.945944073 +0000 UTC m=+244438.478356071: :ballot_box_with_check: agreed by bufferflies.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bufferflies, lhy1024, niubell
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [bufferflies,lhy1024]
- ~~pkg/schedule/schedulers/OWNERS~~ [niubell]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment