pd
pd copied to clipboard
server: skip the engine key when match store label
What problem does this PR solve?
Issue Number: Close #8480.
What is changed and how does it work?
Check List
Tests
- Unit test
Release note
None.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.41%. Comparing base (
838ee79) to head (251b478). Report is 40 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #8486 +/- ##
==========================================
+ Coverage 77.30% 77.41% +0.11%
==========================================
Files 472 472
Lines 61789 61782 -7
==========================================
+ Hits 47766 47831 +65
+ Misses 10448 10381 -67
+ Partials 3575 3570 -5
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 77.41% <100.00%> (+0.11%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
/check-issue-triage-complete
@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
LGTM, But
LocationLabelsseems to have been designed to be equivalent toLabels(if not, ignore it), but now there are other concepts forLabels, such asengine. So it's not clear if there are other places where this gap exists
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JmPotato, nolouch, okJiang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JmPotato,nolouch]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
In response to a cherrypick label: new pull request created to branch release-6.5: #8572.
In response to a cherrypick label: new pull request created to branch release-6.1: #8573.
In response to a cherrypick label: new pull request created to branch release-5.4: #8574.
In response to a cherrypick label: new pull request created to branch release-8.1: #8575.
In response to a cherrypick label: new pull request created to branch release-7.1: #8576.
In response to a cherrypick label: new pull request created to branch release-7.5: #8577.