*: individually check the scheduling halt for online unsafe recovery
What problem does this PR solve?
Issue Number: close #8095, ref #6493.
What is changed and how does it work?
Check List
Tests
- Unit test
- Integration test
Release note
Fix the issue where the cluster cannot recover normally after using the online unsafe recovery.
[REVIEW NOTIFICATION]
This pull request has been approved by:
- HuSharp
- rleungx
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Attention: Patch coverage is 45.45455% with 12 lines in your changes are missing coverage. Please review.
Project coverage is 77.38%. Comparing base (
44d57b6) to head (4d44354).
:exclamation: Current head 4d44354 differs from pull request most recent head 9a4d9c8. Consider uploading reports for the commit 9a4d9c8 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #8147 +/- ##
==========================================
- Coverage 77.44% 77.38% -0.07%
==========================================
Files 471 471
Lines 61348 61347 -1
==========================================
- Hits 47510 47472 -38
- Misses 10278 10310 +32
- Partials 3560 3565 +5
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 77.38% <45.45%> (-0.07%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
/merge
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:
/run-all-tests
You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.
If you have any questions about the PR merge process, please refer to pr process.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
This pull request has been accepted and is ready to merge.
In response to a cherrypick label: new pull request created to branch release-8.1: #8155.
/cherry-pick release-7.1
/cherry-pick release-7.5
@lhy1024: new pull request created to branch release-7.1: #8193.
In response to this:
/cherry-pick release-7.1
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@lhy1024: new pull request created to branch release-7.5: #8194.
In response to this:
/cherry-pick release-7.5
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.