pd icon indicating copy to clipboard operation
pd copied to clipboard

tools: support pd dev

Open HuSharp opened this issue 9 months ago • 5 comments

What problem does this PR solve?

Issue Number: Ref #8135

$ ./bin/pd-dev --mode backup                                                                                                                                                                                  
$ ./bin/pd-dev --mode analysis --input ~/.tiup/data/UBOupkt/pd-0/pd.log --style transfer-counter --operator balance-region
$ ./bin/pd-dev --mode api --http-cases GetRegionStatus-1+1,GetMinResolvedTS-1+1 --client 1 --debug true                                                                                                       
$ ./bin/pd-dev --mode heartbeat --config=./tools/pd-dev/pd-heartbeat-bench/config-template.toml      
image

What is changed and how does it work?

  • support pd-dev to run all tools
  • refine tools code and structure

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

HuSharp avatar Apr 30 '24 07:04 HuSharp

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Apr 30 '24 07:04 ti-chi-bot[bot]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot[bot] avatar Apr 30 '24 07:04 ti-chi-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.33%. Comparing base (2fabb74) to head (1ed11a1).

:exclamation: Current head 1ed11a1 differs from pull request most recent head b9ff645

Please upload reports for the commit b9ff645 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8140      +/-   ##
==========================================
- Coverage   77.34%   77.33%   -0.02%     
==========================================
  Files         471      470       -1     
  Lines       61368    61313      -55     
==========================================
- Hits        47466    47417      -49     
+ Misses      10341    10319      -22     
- Partials     3561     3577      +16     
Flag Coverage Δ
unittests 77.33% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Apr 30 '24 07:04 codecov[bot]

I think for those tools, perhaps we can learn something from [Carge Custom Commands](https://doc.rust-lang.org/cargo/reference/external-tools.html#custom-subcommands).

nolouch avatar May 09 '24 06:05 nolouch

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Jul 05 '24 08:07 ti-chi-bot[bot]