pd icon indicating copy to clipboard operation
pd copied to clipboard

*: add pending task metrics in runner and add templ

Open nolouch opened this issue 1 year ago • 3 comments

What problem does this PR solve?

Issue Number: Ref https://github.com/tikv/pd/issues/7897

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

image

Release note

None.

nolouch avatar Apr 29 '24 08:04 nolouch

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Apr 29 '24 08:04 ti-chi-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.40%. Comparing base (44d57b6) to head (b35c0ce). Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8138      +/-   ##
==========================================
- Coverage   77.44%   77.40%   -0.05%     
==========================================
  Files         471      471              
  Lines       61348    61356       +8     
==========================================
- Hits        47510    47490      -20     
- Misses      10278    10304      +26     
- Partials     3560     3562       +2     
Flag Coverage Δ
unittests 77.40% <100.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Apr 29 '24 09:04 codecov[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar May 07 '24 03:05 ti-chi-bot[bot]

/merge

nolouch avatar May 10 '24 02:05 nolouch

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot[bot] avatar May 10 '24 02:05 ti-chi-bot[bot]

This pull request has been accepted and is ready to merge.

Commit hash: b35c0ceb4bf0ec0ad23619788f740bb5c291dc8f

ti-chi-bot[bot] avatar May 10 '24 02:05 ti-chi-bot[bot]