pd icon indicating copy to clipboard operation
pd copied to clipboard

grpc: allow client send consecutive pings in every 5 seconds

Open yongman opened this issue 10 months ago • 6 comments

What problem does this PR solve?

Issue Number: Close #8119

What is changed and how does it work?

grpc: allow client send consecutive pings in every 5 seconds

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release note

None.

yongman avatar Apr 23 '24 07:04 yongman

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Apr 23 '24 07:04 ti-chi-bot[bot]

Hi @yongman. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 23 '24 07:04 ti-chi-bot[bot]

/ok-to-test

HuSharp avatar Apr 23 '24 09:04 HuSharp

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.25%. Comparing base (ca179e6) to head (43bd742).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8120   +/-   ##
=======================================
  Coverage   77.24%   77.25%           
=======================================
  Files         471      471           
  Lines       61696    61700    +4     
=======================================
+ Hits        47660    47669    +9     
+ Misses      10454    10450    -4     
+ Partials     3582     3581    -1     
Flag Coverage Δ
unittests 77.25% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Apr 23 '24 09:04 codecov[bot]

/check-issue-triage-complete

HuSharp avatar Apr 24 '24 05:04 HuSharp

@HuSharp PTAL

yongman avatar Apr 25 '24 10:04 yongman

@yongman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test 43bd7424f04a7e6b4355ad3104d57853b19659c3 link false /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jul 16 '24 09:07 ti-chi-bot[bot]

/test pull-integration-realcluster-test

HuSharp avatar Jul 16 '24 09:07 HuSharp

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [HuSharp,nolouch]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jul 16 '24 09:07 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-07-08 07:46:01.828817064 +0000 UTC m=+257259.064051177: :ballot_box_with_check: agreed by nolouch.
  • 2024-07-16 09:38:55.636950249 +0000 UTC m=+346757.627891714: :ballot_box_with_check: agreed by HuSharp.

ti-chi-bot[bot] avatar Jul 16 '24 09:07 ti-chi-bot[bot]