pd icon indicating copy to clipboard operation
pd copied to clipboard

metrics: fix patrol panel

Open lhy1024 opened this issue 1 year ago • 2 comments

What problem does this PR solve?

Issue Number: Close #8115

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

tiup play ground with resign leader

Before image

After image

tiup with ms

image

operator with ms

image

Release note

None.

lhy1024 avatar Apr 23 '24 06:04 lhy1024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Apr 23 '24 06:04 ti-chi-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.38%. Comparing base (a3c5950) to head (538e2f3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8116      +/-   ##
==========================================
+ Coverage   77.35%   77.38%   +0.02%     
==========================================
  Files         471      471              
  Lines       61348    61348              
==========================================
+ Hits        47458    47473      +15     
+ Misses      10314    10306       -8     
+ Partials     3576     3569       -7     
Flag Coverage Δ
unittests 77.38% <ø> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Apr 23 '24 07:04 codecov[bot]

max(max(pd_checker_patrol_regions_time{k8s_cluster="$k8s_cluster", tidb_cluster="$tidb_cluster"})by(instance))

We try to build a case, pd_checker_patrol_regions_time in old leader is 12.7ms, pd_checker_patrol_regions_time in new leader is 10.1ms image image

max(max(pd_checker_patrol_regions_time{k8s_cluster="$k8s_cluster", tidb_cluster="$tidb_cluster"})by(instance)) show 10.1 ms image

lhy1024 avatar May 07 '24 17:05 lhy1024

/merge

lhy1024 avatar May 08 '24 07:05 lhy1024

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot[bot] avatar May 08 '24 07:05 ti-chi-bot[bot]

This pull request has been accepted and is ready to merge.

Commit hash: 538e2f33f6dc75bf0fdd37497f8b8d174ee19539

ti-chi-bot[bot] avatar May 08 '24 07:05 ti-chi-bot[bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #8152.

ti-chi-bot avatar May 08 '24 07:05 ti-chi-bot