pd icon indicating copy to clipboard operation
pd copied to clipboard

Patrol concurrency

Open lhy1024 opened this issue 2 months ago • 3 comments

What problem does this PR solve?

Issue Number: Close #xxx

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

lhy1024 avatar Apr 18 '24 08:04 lhy1024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Apr 18 '24 08:04 ti-chi-bot[bot]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot[bot] avatar Apr 18 '24 08:04 ti-chi-bot[bot]

overall lgtm, is this PR ready?

I am preparing some tests for different scenarios

lhy1024 avatar May 14 '24 03:05 lhy1024

Codecov Report

Attention: Patch coverage is 85.26316% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 77.36%. Comparing base (4cd42b3) to head (ab9ef1e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8094      +/-   ##
==========================================
+ Coverage   77.29%   77.36%   +0.07%     
==========================================
  Files         471      471              
  Lines       61445    61515      +70     
==========================================
+ Hits        47491    47590      +99     
+ Misses      10395    10362      -33     
- Partials     3559     3563       +4     
Flag Coverage Δ
unittests 77.36% <85.26%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 24 '24 04:05 codecov[bot]

Codecov Report

Attention: Patch coverage is 85.26316% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 77.46%. Comparing base (4cd42b3) to head (c59b47c). Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8094      +/-   ##
==========================================
+ Coverage   77.29%   77.46%   +0.17%     
==========================================
  Files         471      471              
  Lines       61445    61548     +103     
==========================================
+ Hits        47491    47678     +187     
+ Misses      10395    10306      -89     
- Partials     3559     3564       +5     
Flag Coverage Δ
unittests 77.46% <85.26%> (+0.17%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov-commenter avatar May 24 '24 04:05 codecov-commenter