pd
pd copied to clipboard
tikv
schedule: support patrol region concurrency
What problem does this PR solve?
Issue Number: Close #7963 #7706
What is changed and how does it work?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
Release note
None.
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
overall lgtm, is this PR ready?
I am preparing some tests for different scenarios
Codecov Report
Attention: Patch coverage is 85.26316% with 14 lines in your changes are missing coverage. Please review.
Project coverage is 77.36%. Comparing base (
4cd42b3) to head (ab9ef1e).
Additional details and impacted files
@@ Coverage Diff @@
## master #8094 +/- ##
==========================================
+ Coverage 77.29% 77.36% +0.07%
==========================================
Files 471 471
Lines 61445 61515 +70
==========================================
+ Hits 47491 47590 +99
+ Misses 10395 10362 -33
- Partials 3559 3563 +4
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 77.36% <85.26%> (+0.07%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Attention: Patch coverage is 95.40230% with 4 lines in your changes missing coverage. Please review.
Project coverage is 77.65%. Comparing base (
f3e9d9a) to head (e570e3c). Report is 5 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #8094 +/- ##
========================================
Coverage 77.64% 77.65%
========================================
Files 474 474
Lines 62112 62426 +314
========================================
+ Hits 48228 48474 +246
- Misses 10333 10393 +60
- Partials 3551 3559 +8
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 77.65% <95.40%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Friendly ping @rleungx @JmPotato
There are still many comments that are not being solved.
[LGTM Timeline notifier]
Timeline:
-
2024-06-13 06:42:23.528767754 +0000 UTC m=+619697.582079678: :ballot_box_with_check: agreed by JmPotato. -
2024-06-13 06:42:55.992737053 +0000 UTC m=+619730.046048978: :heavy_multiplication_x::repeat: reset by JmPotato. -
2024-09-25 08:50:25.320316515 +0000 UTC m=+1642295.060740453: :ballot_box_with_check: agreed by okJiang.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: okJiang Once this PR has been reviewed and has the lgtm label, please ask for approval from lhy1024 and additionally assign benmeadowcroft for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment