keyspace level gc: forbid update to ks level gc

[ystaticy]

What problem does this PR solve?

Issue Number: https://github.com/tikv/pd/issues/8061

What is changed and how does it work?

Disables updating gc_management_type to keyspace_level_gc

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Code changes

• Has the configuration change
• Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
• Has persistent data change

Side effects

• Possible performance regression
• Increased code complexity
• Breaking backward compatibility

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• PR to update pingcap/tiup:
• Need to cherry-pick to the release branch

Release note

Disables updating gc_management_type to keyspace_level_gc

[ti-chi-bot[bot]]

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

[ti-chi-bot[bot]]

Hi @ystaticy. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot[bot]]

@AmoebaProtozoa: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[rleungx]

/ok-to-test

[rleungx]

/test all

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.72%. Comparing base (eb03382) to head (5cab5c8). Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8062      +/-   ##
==========================================
+ Coverage   77.61%   77.72%   +0.10%     
==========================================
  Files         474      474              
  Lines       61893    61898       +5     
==========================================
+ Hits        48037    48108      +71     
+ Misses      10317    10243      -74     
- Partials     3539     3547       +8     

Flag	Coverage Δ
unittests	77.72% <100.00%> (+0.10%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

[ystaticy]

/test pull-integration-realcluster-test

[ti-chi-bot[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AmoebaProtozoa, HuSharp, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [HuSharp,rleungx]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot[bot]]

[LGTM Timeline notifier]

Timeline:

• 2024-09-14 03:55:20.192511001 +0000 UTC m=+674189.932934938: :ballot_box_with_check: agreed by rleungx.
• 2024-09-14 06:06:36.903333892 +0000 UTC m=+682066.643757828: :ballot_box_with_check: agreed by HuSharp.