pd icon indicating copy to clipboard operation
pd copied to clipboard

[DNM] rename resolved-ts to watermark

Open zhangjinpeng87 opened this issue 10 months ago • 4 comments

What problem does this PR solve?

Issue Number: Close https://github.com/tikv/tikv/issues/16708

Part of https://github.com/tikv/tikv/issues/16708

What is changed and how does it work?

Rename ResolvedTS to a understandable name Watermark.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

zhangjinpeng87 avatar Apr 01 '24 19:04 zhangjinpeng87

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Apr 01 '24 19:04 ti-chi-bot[bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456, multiple issues should use full syntax for each issue and be separated by a comma, like: Issue Number: close #123, ref #456.

:open_book: For more info, you can check the "Linking issues" section in the CONTRIBUTING.md.

ti-chi-bot[bot] avatar Apr 01 '24 19:04 ti-chi-bot[bot]

@zhangjinpeng87: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci/build bdc58713e90e43086683572b7aaad5e6d399b84b link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Apr 01 '24 19:04 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 03 '24 09:04 ti-chi-bot[bot]