pd icon indicating copy to clipboard operation
pd copied to clipboard

client: return total wait duration in resource interceptor OnRequestWait call (#7488)

Open ti-chi-bot opened this issue 1 year ago • 3 comments

This is an automated cherry-pick of #7488

What problem does this PR solve?

Issue Number: ref #5851

What is changed and how does it work?

return total wait duration in resource interceptor OnRequestWait call so we can track the wait duration in tidb slow log.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None.

ti-chi-bot avatar Feb 02 '24 09:02 ti-chi-bot

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Feb 02 '24 09:02 ti-chi-bot[bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Feb 02 '24 09:02 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Jul 05 '24 08:07 ti-chi-bot[bot]

Confirmed with @glorv, release-7.1 doesn't need this cp.

rleungx avatar Sep 13 '24 07:09 rleungx