pd icon indicating copy to clipboard operation
pd copied to clipboard

mcs: force load when rule watcher meet error

Open lhy1024 opened this issue 1 year ago • 5 comments

What problem does this PR solve?

Issue Number: Close #xxx

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

lhy1024 avatar Dec 21 '23 15:12 lhy1024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Dec 21 '23 15:12 ti-chi-bot[bot]

Codecov Report

Merging #7607 (36da56e) into master (754095a) will decrease coverage by 0.06%. Report is 54 commits behind head on master. The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7607      +/-   ##
==========================================
- Coverage   73.87%   73.81%   -0.06%     
==========================================
  Files         429      429              
  Lines       47376    47391      +15     
==========================================
- Hits        35000    34984      -16     
- Misses       9392     9415      +23     
- Partials     2984     2992       +8     
Flag Coverage Δ
unittests 73.81% <50.00%> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 21 '23 15:12 codecov[bot]

Issue Number?

CabinfeverB avatar Dec 22 '23 09:12 CabinfeverB

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456, multiple issues should use full syntax for each issue and be separated by a comma, like: Issue Number: close #123, ref #456.

:open_book: For more info, you can check the "Linking issues" section in the CONTRIBUTING.md.

ti-chi-bot[bot] avatar Jan 04 '24 15:01 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Feb 03 '24 08:02 ti-chi-bot[bot]