pd icon indicating copy to clipboard operation
pd copied to clipboard

*: check raftcluster nil (#7054)

Open ti-chi-bot opened this issue 2 years ago • 7 comments

This is an automated cherry-pick of #7054

What problem does this PR solve?

Issue Number: Close #7053

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

ti-chi-bot avatar Sep 11 '23 07:09 ti-chi-bot

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot[bot] avatar Sep 11 '23 07:09 ti-chi-bot[bot]

/test

HuSharp avatar Sep 20 '23 05:09 HuSharp

@HuSharp: No presubmit jobs available for tikv/[email protected]

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Sep 20 '23 05:09 ti-chi-bot[bot]

Codecov Report

Attention: Patch coverage is 43.75000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 74.60%. Comparing base (21b47d2) to head (ae68a09).

Files Patch % Lines
server/server.go 41.66% 9 Missing and 5 partials :warning:
server/handler.go 50.00% 2 Missing and 2 partials :warning:
Additional details and impacted files
@@               Coverage Diff               @@
##           release-5.4    #7068      +/-   ##
===============================================
- Coverage        74.80%   74.60%   -0.21%     
===============================================
  Files              265      265              
  Lines            28019    28032      +13     
===============================================
- Hits             20961    20913      -48     
- Misses            5216     5254      +38     
- Partials          1842     1865      +23     
Flag Coverage Δ
unittests 74.60% <43.75%> (-0.21%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 23 '24 11:02 codecov[bot]

/merge

HuSharp avatar Feb 26 '24 01:02 HuSharp

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot[bot] avatar Feb 26 '24 01:02 ti-chi-bot[bot]

This pull request has been accepted and is ready to merge.

Commit hash: ae68a09ec99cf0718fdf172aa00b1434ae6ebd0a

ti-chi-bot[bot] avatar Feb 26 '24 01:02 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, JmPotato, lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [HuSharp,JmPotato,lhy1024,rleungx]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 14 '24 02:09 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-09-14 02:43:34.646807839 +0000 UTC m=+669884.387231782: :ballot_box_with_check: agreed by rleungx.
  • 2024-09-14 02:57:49.60476818 +0000 UTC m=+670739.345192118: :ballot_box_with_check: agreed by lhy1024.

ti-chi-bot[bot] avatar Sep 14 '24 02:09 ti-chi-bot[bot]