pd
pd copied to clipboard
*: refactor store info
What problem does this PR solve?
Issue Number: Ref #7897
What is changed and how does it work?
Check List
Tests
- Unit test
Release note
None.
[REVIEW NOTIFICATION]
This pull request has been approved by:
- JmPotato
- nolouch
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Codecov Report
Attention: Patch coverage is 90.06623%
with 15 lines
in your changes are missing coverage. Please review.
Project coverage is 77.31%. Comparing base (
9d580d0
) to head (a0f722f
).
Additional details and impacted files
@@ Coverage Diff @@
## master #6830 +/- ##
==========================================
- Coverage 77.38% 77.31% -0.07%
==========================================
Files 471 471
Lines 61457 61317 -140
==========================================
- Hits 47557 47407 -150
- Misses 10338 10347 +9
- Partials 3562 3563 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 77.31% <90.06%> (-0.07%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/merge
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:
/run-all-tests
You only need to trigger /merge
once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.
If you have any questions about the PR merge process, please refer to pr process.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
This pull request has been accepted and is ready to merge.
@rleungx: Your PR was out of date, I have automatically updated it for you.
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.