utils: use `keyutil` pkg to simply the code
What problem does this PR solve?
Issue Number: Close #xxx
What is changed and how does it work?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Code changes
- Has the configuration change
- Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
- Has persistent data change
Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
Related changes
- PR to update
pingcap/docs/pingcap/docs-cn: - PR to update
pingcap/tiup: - Need to cherry-pick to the release branch
Release note
None.
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
[FORMAT CHECKER NOTIFICATION]
Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456, multiple issues should use full syntax for each issue and be separated by a comma, like: Issue Number: close #123, ref #456.
:open_book: For more info, you can check the "Linking issues" section in the CONTRIBUTING.md.
Codecov Report
Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.
Project coverage is 75.02%. Comparing base (
99742e9) to head (846c19c). Report is 1090 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/statistics/buckets/hot_bucket_cache.go | 92.30% | 0 Missing and 1 partial :warning: |
| pkg/utils/keyutil/util.go | 93.75% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #6443 +/- ##
==========================================
- Coverage 75.20% 75.02% -0.19%
==========================================
Files 408 409 +1
Lines 41120 41493 +373
==========================================
+ Hits 30926 31131 +205
- Misses 7515 7654 +139
- Partials 2679 2708 +29
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 75.02% <95.55%> (-0.19%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/close
@bufferflies: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.