pd
pd copied to clipboard
*: fix the gctuner tests
What problem does this PR solve?
Issue Number: Close #5953.
What is changed and how does it work?
Enable all gctuner-related tests.
Check List
Tests
- Unit test
Release note
None.
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.45%. Comparing base (
7ef2be0
) to head (c05c0f8
).
Additional details and impacted files
@@ Coverage Diff @@
## master #6330 +/- ##
==========================================
+ Coverage 77.34% 77.45% +0.10%
==========================================
Files 472 472
Lines 61796 61796
==========================================
+ Hits 47799 47866 +67
+ Misses 10433 10376 -57
+ Partials 3564 3554 -10
Flag | Coverage Δ | |
---|---|---|
unittests | 77.45% <100.00%> (+0.10%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
still failed
--- FAIL: TestTuner (1.35s)
tuner_test.go:59:
Error Trace: /home/runner/work/pd/pd/pkg/gctuner/tuner_test.go:59
Error: Condition never satisfied
Test: TestTuner
/test ?
@rleungx: The following commands are available to trigger required jobs:
-
/test build
The following commands are available to trigger optional jobs:
-
/test pull-integration-copr-test
-
/test pull-integration-realcluster-test
Use /test all
to run the following jobs that were automatically triggered:
-
tikv/pd/ghpr_build
-
tikv/pd/pull_integration_realcluster_test
In response to this:
/test ?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/test all
/test pull-integration-realcluster-test
/test pull-integration-realcluster-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JmPotato, lhy1024
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JmPotato,lhy1024]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment