pd icon indicating copy to clipboard operation
pd copied to clipboard

server: fixed bootstrap when disk low

Open HuSharp opened this issue 2 years ago • 15 comments

What problem does this PR solve?

Issue Number: Close #6311

What is changed and how does it work?

When gRPC context deadline exceeded, but etcd still finished the txn, for this case heed to check region value.

Check List

Tests

  • Integration test

Release note

None.

HuSharp avatar Apr 13 '23 09:04 HuSharp

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Apr 13 '23 09:04 ti-chi-bot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot avatar Apr 13 '23 09:04 ti-chi-bot

Codecov Report

:x: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 75.09%. Comparing base (e75eef1) to head (1bc7487). :warning: Report is 1501 commits behind head on master.

Files with missing lines Patch % Lines
server/server.go 28.57% 3 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6319      +/-   ##
==========================================
- Coverage   75.12%   75.09%   -0.04%     
==========================================
  Files         405      405              
  Lines       40117    40122       +5     
==========================================
- Hits        30138    30129       -9     
- Misses       7350     7359       +9     
- Partials     2629     2634       +5     
Flag Coverage Δ
unittests 75.09% <28.57%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 13 '23 10:04 codecov[bot]

Do we need to pick it to other branches?

lhy1024 avatar Apr 18 '23 04:04 lhy1024

/merge

JmPotato avatar Apr 18 '23 05:04 JmPotato

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Apr 18 '23 05:04 ti-chi-bot

This pull request has been accepted and is ready to merge.

Commit hash: 68ca92e416b81499003bf577c492a57d5c8b7b3d

ti-chi-bot avatar Apr 18 '23 05:04 ti-chi-bot

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Apr 18 '23 05:04 ti-chi-bot

/hold

CabinfeverB avatar Apr 18 '23 05:04 CabinfeverB

/merge

lhy1024 avatar Apr 18 '23 06:04 lhy1024

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Apr 18 '23 06:04 ti-chi-bot

This pull request has been accepted and is ready to merge.

Commit hash: b14f0193376c7ea5060113e30ccf8db37aa5e795

ti-chi-bot avatar Apr 18 '23 06:04 ti-chi-bot

/hold

lhy1024 avatar Apr 18 '23 06:04 lhy1024

Merge canceled because a new commit is pushed.

ti-chi-bot avatar Apr 18 '23 08:04 ti-chi-bot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Sep 27 '24 09:09 ti-chi-bot[bot]

@HuSharp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-next-gen-1 1bc748726a44b4db3122bc6b1c69dc5e8769f94a link true /test pull-unit-test-next-gen-1
pull-unit-test-next-gen-3 1bc748726a44b4db3122bc6b1c69dc5e8769f94a link true /test pull-unit-test-next-gen-3
pull-unit-test-next-gen-2 1bc748726a44b4db3122bc6b1c69dc5e8769f94a link true /test pull-unit-test-next-gen-2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Dec 04 '25 10:12 ti-chi-bot[bot]