pd icon indicating copy to clipboard operation
pd copied to clipboard

scheduler: add comment for grant hot leader scheduler

Open lhy1024 opened this issue 3 years ago • 3 comments

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: Ref #4399

Check List

Tests

  • No code

Release note

 None.

lhy1024 avatar May 07 '22 09:05 lhy1024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar May 07 '22 09:05 ti-chi-bot

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.66%. Comparing base (f3e9d9a) to head (1f7991c). Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4903      +/-   ##
==========================================
+ Coverage   77.64%   77.66%   +0.02%     
==========================================
  Files         474      474              
  Lines       62112    62140      +28     
==========================================
+ Hits        48228    48264      +36     
+ Misses      10333    10321      -12     
- Partials     3551     3555       +4     
Flag Coverage Δ
unittests 77.66% <74.19%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 07 '22 09:05 codecov[bot]

/hold

lhy1024 avatar May 16 '22 07:05 lhy1024

/hold

lhy1024 avatar Sep 13 '24 08:09 lhy1024

/retest

lhy1024 avatar Sep 23 '24 02:09 lhy1024

LGTM

bufferflies avatar Sep 24 '24 02:09 bufferflies

/unhold it still need an approve

lhy1024 avatar Sep 24 '24 02:09 lhy1024

@lhy1024: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

In response to removing label named needs-1-more-lgtm.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot[bot] avatar Sep 25 '24 08:09 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [JmPotato,bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 25 '24 08:09 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 08:10:14.74561145 +0000 UTC m=+1639884.486035389: :ballot_box_with_check: agreed by rleungx.
  • 2024-09-25 08:37:58.385691774 +0000 UTC m=+1641548.126115729: :ballot_box_with_check: agreed by JmPotato.

ti-chi-bot[bot] avatar Sep 25 '24 08:09 ti-chi-bot[bot]

@lhy1024: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test 1f7991c4963500cb59ff177cee1d0fab5bbf523b link false /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Sep 25 '24 08:09 ti-chi-bot[bot]