migration icon indicating copy to clipboard operation
migration copied to clipboard

Use new gc safepoint update interface

Open haojinming opened this issue 3 years ago • 5 comments

Bug Report

1. Describe the bug

Use new gc safepoint update interface

2. Minimal reproduce step (Required)

3. What did you see instead (Required)

4. What did you expect to see? (Required)

Use new gc safepoint update interface

5. What is your migration tool and TiKV version? (Required)

GC-Worker

haojinming avatar May 10 '22 07:05 haojinming

Still get & pass revision to update GC safe point interface. p.s. In this scenario, revision will be `-1.

pingyu avatar May 10 '22 08:05 pingyu

@pingyu What revision is returned from GetGCMinServiceSafePointByServiceGroup interface in this scenario? Could gc-worker pass the returned revision to UpdateGCSafePointByServiceGroup or need hard code to -1?

haojinming avatar May 10 '22 08:05 haojinming

@pingyu What revision is returned from GetGCMinServiceSafePointByServiceGroup interface in this scenario?

-1. See here.

Could gc-worker pass the returned revision to UpdateGCSafePointByServiceGroup or need hard code to -1?

Yes. No hard code is needed.

pingyu avatar May 10 '22 08:05 pingyu

ok, get it.

haojinming avatar May 10 '22 08:05 haojinming

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Jun 10 '22 02:06 github-actions[bot]