jemallocator icon indicating copy to clipboard operation
jemallocator copied to clipboard
verified publisher icon tikv

set `--disable-stats` if `stats` feature is not enabled

Open x86pup opened this issue 1 year ago • 2 comments

jemalloc defaults to enabling stats if --enable-stats is not present and --disable-stats was not set: https://github.com/jemalloc/jemalloc/blob/fa451de17fff73cc03c31ec8cd817d62927d1ff9/configure.ac#L1331-L1333

This issue was observed when we were building with stats and noticed the output of malloc_stats_print was basically the same.

Before: image

After: image

x86pup avatar Apr 28 '24 14:04 x86pup

It's better to add it in the default feature list in this PR. This is still a breaking change for those rely on stats features without enabling it explicitly though.

BusyJay avatar Apr 29 '24 03:04 BusyJay

@BusyJay Added it to the default features

x86pup avatar Apr 29 '24 03:04 x86pup

@BusyJay Anything blocking this PR from being merged? The CI failure looks to be out of my control, the runner timed out. Everything else still passed.

x86pup avatar May 09 '24 16:05 x86pup

Thanks!

BusyJay avatar May 10 '24 02:05 BusyJay