jemallocator icon indicating copy to clipboard operation
jemallocator copied to clipboard

Remove build directory once build of `jemalloc-sys` finishes

Open Kobzol opened this issue 10 months ago • 4 comments

And link to the libraries installed with make install instead. This saves disk space in the target directory. When you build jemalloc multiple times, with different Cargo profiles, RUSTFLAGS etc., the files on disk will begin accumulating for no reason (if there is a change, Cargo will just rebuild the library in a different directory).

Target directory disk space usage is a big concern to Rust users (https://blog.rust-lang.org/2025/02/13/2024-State-Of-Rust-Survey-results.html#challenges), and jemalloc is quite popular, so I think that it would be nice to improve this.

Fixes: https://github.com/tikv/jemallocator/issues/89

Kobzol avatar Feb 17 '25 09:02 Kobzol

Welcome @Kobzol! It looks like this is your first PR to tikv/jemallocator 🎉

ti-chi-bot[bot] avatar Feb 17 '25 09:02 ti-chi-bot[bot]

The contributing guide link is 404. Do you have any suggestion on how to do the DCO sign-off?

Kobzol avatar Feb 18 '25 08:02 Kobzol

Added the signoff.

Kobzol avatar Mar 03 '25 11:03 Kobzol

@BusyJay What do you think about this? :)

Kobzol avatar Jun 13 '25 03:06 Kobzol

@BusyJay ping :)

Kobzol avatar Dec 10 '25 18:12 Kobzol

You need to rebase master

BusyJay avatar Dec 11 '25 06:12 BusyJay

Done. I also ignored any potential errors, so that they don't impact the result of the build.

Kobzol avatar Dec 11 '25 06:12 Kobzol

Thanks!

BusyJay avatar Dec 11 '25 10:12 BusyJay