jemallocator icon indicating copy to clipboard operation
jemallocator copied to clipboard

Update VERSION check in configure script to use BRE

Open Gumnos opened this issue 1 year ago • 5 comments

POSIX BRE doesn't support \+ so the grep fails on OpenBSD. Modify the version-check to use proper BRE

Fixes #112

Gumnos avatar Jan 02 '25 01:01 Gumnos

Welcome @Gumnos! It looks like this is your first PR to tikv/jemallocator 🎉

ti-chi-bot[bot] avatar Jan 02 '25 01:01 ti-chi-bot[bot]

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • e334e21 Update VERSION check in configure script to use BRE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jan 02 '25 01:01 ti-chi-bot[bot]

The link to the CONTRIBUTING.md is broken, so I'm uncertain how to go about updating my commits with the DCO. It's a one-line change.

Gumnos avatar Jan 02 '25 01:01 Gumnos

As per https://github.com/tikv/jemallocator/pull/113/checks?check_run_id=35052044761

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

sxyazi avatar Jan 02 '25 15:01 sxyazi

Can you also send this PR to https://github.com/jemalloc/jemalloc?

BusyJay avatar Jan 06 '25 07:01 BusyJay