jemallocator icon indicating copy to clipboard operation
jemallocator copied to clipboard

Vesion is too long

Open bistack opened this issue 1 year ago • 4 comments

v0.6.0+5.3.0-1-ge13ca993e8ccb9ba9847cc330696e02839f328f7

What is the last part? Is the jemalloc gid? It's not match 5.3.0's gid.

Just v0.6.0+5.3.0 is fine.

bistack avatar Dec 24 '24 11:12 bistack

It's the ref (version and commit hash) of bundled jemalloc. What problem did you meet exactly?

BusyJay avatar Dec 24 '24 12:12 BusyJay

I guess that it's typo in git commit hash, i.e. https://github.com/jemalloc/jemalloc/commit/ge13ca993e8ccb9ba9847cc330696e02839f328f7 not exist, while https://github.com/jemalloc/jemalloc/commit/e13ca993e8ccb9ba9847cc330696e02839f328f7 exist and points to correct commit.

klensy avatar Dec 27 '24 09:12 klensy

The hash points to https://github.com/tikv/jemalloc/commit/e13ca993e8ccb9ba9847cc330696e02839f328f7 , it's generated by git describe.

BusyJay avatar Dec 27 '24 10:12 BusyJay

I mean this is literally the committed line, 41 chars is not a SHA-1 hash name, thank you @bistack for reporting 👍 https://github.com/tikv/jemallocator/blob/f260a80f21b7f9eb1212809720d9a5f7f0cf0e8b/jemalloc-sys/Cargo.toml#L3

@BusyJay Would it be possible to use a normal semver or at least the correct hash?

By the way, e13ca99 is outdated, the last one is 09ad115 https://github.com/tikv/jemalloc/commits/5.3.x/

reneleonhardt avatar Jun 28 '25 17:06 reneleonhardt