grpc-rs icon indicating copy to clipboard operation
grpc-rs copied to clipboard

remove deprecated method to avoid warning

Open hxingpax opened this issue 11 months ago • 5 comments

fix warning of cargo test:

warning: use of deprecated method `cmake::Config::uses_cxx11`: no longer does anything, C++ is determined based on `cc::Build`, and the macOS issue has been fixed upstream
   --> grpc-sys/build.rs:255:16
    |
255 |         config.uses_cxx11().build()
    |                ^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

hxingpax avatar Feb 11 '25 08:02 hxingpax

Welcome @hxingpax! It looks like this is your first PR to tikv/grpc-rs 🎉

ti-chi-bot[bot] avatar Feb 11 '25 08:02 ti-chi-bot[bot]

Hi, failed CI is not related to your changes, but can you also fix them in this PR?

BusyJay avatar Feb 11 '25 16:02 BusyJay

I'll chime in since @BusyJay and I discus this issue in #654 and related context to cc-rs and cmake. I'd suggest removing this from the documentation comment and example in cross_compile.md under All diff in fn build_grpc

taddes avatar Feb 11 '25 16:02 taddes

Friendly ping.

Hi, @hxingpax do you still have time to work on this?

BusyJay avatar Feb 21 '25 02:02 BusyJay

Hey @BusyJay , I'm finally getting to this and have my PR, however the link to the docs on setting up DCO commits is dead in the ti-chi-bot message, as there's no Contributing doc. My commits are GPG signed, as we have that policy over at Mozilla.

taddes avatar Apr 10 '25 19:04 taddes