grpc-rs icon indicating copy to clipboard operation
grpc-rs copied to clipboard

System libraries versions (grpc)

Open gabriel-doriath-dohler opened this issue 3 years ago • 6 comments

Is there a way to retrieve the correct (and tested) versions for system libraries such as grpc? Currently, it can be extracted using cargo metadata and sed 's/^.*+//;s/-.*$//', as the grpcio-sys version includes the grpc version. Will this be stable or will the naming convention change?

gabriel-doriath-dohler avatar Oct 13 '22 14:10 gabriel-doriath-dohler

Why do you want that library?

BusyJay avatar Oct 13 '22 15:10 BusyJay

I'm using pkg-config and GRPCIO_SYS_USE_PKG_CONFIG=1, so I need to know the correct grpc version. Currently I'm using the grpc version from the grpcio-sys version. For example, I'm using grpc 1.44.0 for grpcio-sys v0.10.3+1.44.0-patched.

gabriel-doriath-dohler avatar Oct 13 '22 15:10 gabriel-doriath-dohler

If the naming convention for grpcio-sys versions change, my regexpr will not work. So, will the convention change or do you provide any other stable way to get the correct grpc version?

gabriel-doriath-dohler avatar Oct 13 '22 15:10 gabriel-doriath-dohler

Currently TiKV's version include a patch that is not merged into upstream. https://github.com/pingcap/grpc/commit/38a9cd9d632e4eba70790525abf38674251eb2a0. So use customized library may miss the functionality. I would not say the format of grpcio-sys version name is reliable. But I don't see it will change in the near future. The format is {grpcio-sys version}+{grpc version}[-patched[.1]. -patched part means whether we have included unreleased patch based on the grpc version. -patched.1 means more patches than -patched are included in the grpc.

BusyJay avatar Oct 13 '22 16:10 BusyJay

Thanks a lot! Where can I get a list of all patches that are not merged upstream, so that I can apply them?

gabriel-doriath-dohler avatar Oct 13 '22 16:10 gabriel-doriath-dohler

Currently there is only one functionality difference. You can get what's changed by git diff {grpcio-sys version}.

BusyJay avatar Oct 14 '22 02:10 BusyJay