client-java icon indicating copy to clipboard operation
client-java copied to clipboard

[close #654] Add RegionCacheInvalidCallBack

Open qidi1 opened this issue 3 years ago • 3 comments

Signed-off-by: qidi1 [email protected]

What problem does this PR solve?

Issue Number: close #654

Problem Description: TBD

What is changed and how does it work?

Add RegionCacheInvalidCallBack. Let the upper layers customize their own behavior when the region cache fails.

Code changes

  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test

Side effects

  • NO side effects

Related changes

  • NO related changes

qidi1 avatar Sep 22 '22 03:09 qidi1

Codecov Report

Base: 37.65% // Head: 37.97% // Increases project coverage by +0.32% :tada:

Coverage data is based on head (21354fa) compared to base (d278e3a). Patch coverage: 73.68% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #653      +/-   ##
============================================
+ Coverage     37.65%   37.97%   +0.32%     
- Complexity     1589     1603      +14     
============================================
  Files           278      278              
  Lines         17420    17462      +42     
  Branches       1982     1984       +2     
============================================
+ Hits           6559     6631      +72     
+ Misses        10207    10175      -32     
- Partials        654      656       +2     
Impacted Files Coverage Δ
.../org/tikv/common/operation/RegionErrorHandler.java 50.32% <55.88%> (+15.16%) :arrow_up:
...va/org/tikv/common/event/CacheInvalidateEvent.java 36.84% <100.00%> (+36.84%) :arrow_up:
...ain/java/org/tikv/common/region/RegionManager.java 82.14% <100.00%> (+1.49%) :arrow_up:
src/main/java/org/tikv/txn/TxnExpireTime.java 63.15% <0.00%> (-10.53%) :arrow_down:
...rc/main/java/io/grpc/netty/NettyClientHandler.java 53.23% <0.00%> (-0.87%) :arrow_down:
src/main/java/org/tikv/common/codec/Codec.java 23.93% <0.00%> (-0.33%) :arrow_down:
...java/org/tikv/common/region/RegionStoreClient.java 57.47% <0.00%> (+0.29%) :arrow_up:
src/main/java/io/grpc/stub/ClientCalls.java 48.51% <0.00%> (+2.31%) :arrow_up:
src/main/java/io/grpc/internal/ClientCallImpl.java 59.07% <0.00%> (+2.42%) :arrow_up:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 23 '22 02:09 codecov[bot]

Please open an issue to describe it.

iosmanthus avatar Sep 23 '22 02:09 iosmanthus

@shiyuhang0, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader.

ti-srebot avatar Sep 29 '22 06:09 ti-srebot

This PR is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this PR will be closed in 7 days.

github-actions[bot] avatar Oct 30 '22 01:10 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Nov 07 '22 00:11 github-actions[bot]

cherry pick to release-3.3 in PR #715

ti-srebot avatar Jan 30 '23 07:01 ti-srebot